Bug 221301 - [LFC][IFC] Remove font.size() == 0 optimization in TextUtil::width
Summary: [LFC][IFC] Remove font.size() == 0 optimization in TextUtil::width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-02 15:31 PST by zalan
Modified: 2021-02-03 07:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2021-02-02 15:32 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-02-02 15:31:06 PST 
It does not work with tabs (e.g. tab-size property) and probably not much of a win either.
Comment 1 zalan 2021-02-02 15:32:56 PST 
Created attachment 419074 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-02-02 21:06:04 PST 
Comment on attachment 419074 [details]
Patch

No test with tab-size?
Comment 3 zalan 2021-02-03 06:44:29 PST 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 419074 [details]
> Patch
> 
> No test with tab-size?
imported/w3c/web-platform-tests/css/css-text/white-space/white-space-zero-fontsize-002.html
Comment 4 EWS 2021-02-03 07:08:42 PST 
commit-queue failed to commit attachment 419074 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-02-03 07:34:21 PST 
Committed r272314: <https://trac.webkit.org/changeset/272314>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419074 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-03 07:35:16 PST 
<rdar://problem/73931522>