Bug 221222 - [webkitscmpy] Interprocess lock waits indefinitely
Summary: [webkitscmpy] Interprocess lock waits indefinitely
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-01 13:13 PST by Don Olmstead
Modified: 2021-02-08 13:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.12 KB, patch)
2021-02-02 09:11 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-02-01 13:13:35 PST 
The fasteners.process_lock.InterProcessLock when used in a with block will wait indefinitely for the lock to be available. This can cause tests to hang indefinitely. Suggestion is to create the lock and manually acquire with a timeout and do a release.
Comment 1 Don Olmstead 2021-02-02 09:11:23 PST 
Created attachment 419007 [details]
Patch
Comment 2 Jonathan Bedard 2021-02-02 10:20:39 PST 
Don and I discussed this on Slack. Long term, this may be correct, but the root of this problem on Windows may be the fact that we're using threads instead of processes. https://bugs.webkit.org/show_bug.cgi?id=217680 is going to fix that, so for now, we're going to skip the effected tests on Windows.
Comment 3 Radar WebKit Bug Importer 2021-02-08 13:14:14 PST 
<rdar://problem/74110831>