Bug 221206 - [SOUP] Stop using SoupBuffer in preparation for libsoup3
Summary: [SOUP] Stop using SoupBuffer in preparation for libsoup3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: libsoup3
  Show dependency tree / graph
 
Reported: 2021-02-01 07:13 PST by Carlos Garcia Campos
Modified: 2021-02-02 00:52 PST (History)
11 users (show)

See Also:

Attachments
Patch (35.36 KB, patch)
2021-02-01 07:16 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (35.36 KB, patch)
2021-02-01 07:56 PST, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-02-01 07:13:29 PST 
It's gone in libsoup3, we can just use GBytes instead.
Comment 1 Carlos Garcia Campos 2021-02-01 07:16:48 PST 
Created attachment 418870 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-02-01 07:56:22 PST 
Created attachment 418874 [details]
Patch
Comment 3 Sergio Villar Senin 2021-02-01 08:03:18 PST 
Comment on attachment 418874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418874&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69
> +        SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr),

auto* soupBuffer ?

Also I guess this would be migrated later right? Consider adding a comment.
Comment 4 Adrian Perez 2021-02-01 08:19:41 PST 
Comment on attachment 418874 [details]
Patch

LGTM as well

View in context: https://bugs.webkit.org/attachment.cgi?id=418874&action=review

>> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69
>> +        SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr),
> 
> auto* soupBuffer ?
> 
> Also I guess this would be migrated later right? Consider adding a comment.

I assume that there will be later a patch adding the support to actually
use libsoup3 inside “#if SOUP_CHECK_VERSION(2, 91, 0)” guards (or similar) and
this version of the code will be in the “#else” arm of the conditional =]
Comment 5 Carlos Garcia Campos 2021-02-02 00:51:01 PST 
(In reply to Adrian Perez from comment #4)
> Comment on attachment 418874 [details]
> Patch
> 
> LGTM as well
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418874&action=review
> 
> >> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69
> >> +        SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr),
> > 
> > auto* soupBuffer ?
> > 
> > Also I guess this would be migrated later right? Consider adding a comment.
> 
> I assume that there will be later a patch adding the support to actually
> use libsoup3 inside “#if SOUP_CHECK_VERSION(2, 91, 0)” guards (or similar)
> and
> this version of the code will be in the “#else” arm of the conditional =]

Exactly, it will be kept in the libsoup2 branch
Comment 6 Carlos Garcia Campos 2021-02-02 00:52:51 PST 
Committed r272196: <https://trac.webkit.org/changeset/272196>