Bug 221080 - REGRESSION (r271988): XRSession.end() promise is not resolved if PlatformXR::Device::supportsSessionShutdownNotification() returns false
Summary: REGRESSION (r271988): XRSession.end() promise is not resolved if PlatformXR::...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 21:53 PST by Ada Chan
Modified: 2021-01-28 08:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.60 KB, patch)
2021-01-27 22:10 PST, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-01-27 21:53:07 PST 
This is a regression from https://bugs.webkit.org/show_bug.cgi?id=220835.

In that change, m_endPromise was saved after the call to WebXRSession::shutdown(InitiatedBySystem::No), but that call could result in WebXRSession::didCompleteShutdown() if the device returns false for supportsSessionShutdownNotification() and m_endPromise would still be null then.

Not sure why xrSession_end.https.html did not time out like I've seen with xrSession_requestAnimationFrame_callback_calls.https.html.
Comment 1 Ada Chan 2021-01-27 21:58:42 PST 
Regression point is https://trac.webkit.org/changeset/271988/webkit
Comment 2 Ada Chan 2021-01-27 22:10:20 PST 
Created attachment 418619 [details]
Patch
Comment 3 EWS 2021-01-28 08:32:55 PST 
Committed r272014: <https://trac.webkit.org/changeset/272014>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418619 [details].
Comment 4 Radar WebKit Bug Importer 2021-01-28 08:33:14 PST 
<rdar://problem/73709519>