Bug 221049 - [GTK] run-gtk-tests: Ensure correct count when subtests are specified
Summary: [GTK] run-gtk-tests: Ensure correct count when subtests are specified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 10:50 PST by Alicia Boya García
Modified: 2021-01-28 06:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2021-01-27 10:51 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-01-27 10:50:04 PST 
Currently the code of run-gtk-tests adds the number of skipped tests
to the count of total tests. That computation failed to take into
account the case where specific subtests are run (by means of passing
the -p argument), instead of the full test suite.

This patch fixes that, only adding to "total tests" those skipped
subtests that were also specified with the -p argument when using that
mode.
Comment 1 Alicia Boya García 2021-01-27 10:51:40 PST 
Created attachment 418560 [details]
Patch
Comment 2 EWS 2021-01-28 06:25:11 PST 
Committed r272013: <https://trac.webkit.org/changeset/272013>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418560 [details].
Comment 3 Radar WebKit Bug Importer 2021-01-28 06:26:14 PST 
<rdar://problem/73706572>