Bug 220854 - Remove individual settings accessors from WorkerGlobalScope and add Settings::Values accessor
Summary: Remove individual settings accessors from WorkerGlobalScope and add Settings:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks: 202793
  Show dependency tree / graph
 
Reported: 2021-01-22 02:38 PST by Chris Lord
Modified: 2021-01-22 04:12 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.57 KB, patch)
2021-01-22 02:42 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2021-01-22 03:26 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2021-01-22 02:38:08 PST 
Currently, some individual settings are accessible via WorkerGlobalScope, but this isn't really a tenable way to do things long-term. I suggest removing these and just making the Settings::Values accessible. This is useful for OffscreenCanvas which requires a bunch of font-related settings that would be tedious to write a bunch of new accessors for.
Comment 1 Chris Lord 2021-01-22 02:42:04 PST 
Created attachment 418127 [details]
Patch
Comment 2 Chris Lord 2021-01-22 03:26:37 PST 
Created attachment 418132 [details]
Patch
Comment 3 EWS 2021-01-22 04:11:43 PST 
Committed r271743: <https://trac.webkit.org/changeset/271743>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418132 [details].
Comment 4 Radar WebKit Bug Importer 2021-01-22 04:12:14 PST 
<rdar://problem/73493954>