WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
220846
WebGL powerPreference is not tested
https://bugs.webkit.org/show_bug.cgi?id=220846
Summary
WebGL powerPreference is not tested
Kimmo Kinnunen
Reported
2021-01-22 00:16:23 PST
Needs - tests - interface to check if integrated GPU is on - interface to check if has discrete GPU - interface to flush the shutdown timer of discrete GPU
Attachments
Patch
(3.11 KB, patch)
2021-01-22 00:23 PST
,
Kimmo Kinnunen
kbr
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2021-01-22 00:23:21 PST
Created
attachment 418113
[details]
Patch
Kenneth Russell
Comment 2
2021-01-23 00:25:02 PST
Comment on
attachment 418113
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418113&action=review
Looks good to me. r+
> LayoutTests/fast/canvas/webgl/high-performance-context.html:14 > +description("Tests that a high-performance contexts do not fail.");
"contexts do not" -> "context does not"
> LayoutTests/fast/canvas/webgl/high-performance-context.html:19 > +var wtu = WebGLTestUtils;
Nowadays, prefer "let" (or "const") over "var".
Kenneth Russell
Comment 3
2021-01-26 17:26:15 PST
In case they're useful, here are some related tests run against Chromium:
https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/gpu_process_integration_test.py;l=112?q=gpu_process_integration_test
https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_test_pages.py;l=642
the latter of which reference helper functions in this file:
https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_integration_test.py;l=221
Radar WebKit Bug Importer
Comment 4
2021-01-29 00:17:17 PST
<
rdar://problem/73744012
>
Ahmad Saleem
Comment 5
2022-10-25 13:32:10 PDT
Looks like this r+ patch didn't landed and I checked via BugID on Webkit GitHub. Just wanted to update. Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug