Bug 220800 - [webkitscmpy] Handle machines that cannot import keyring
Summary: [webkitscmpy] Handle machines that cannot import keyring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-21 09:05 PST by Jonathan Bedard
Modified: 2021-01-21 09:55 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2021-01-21 09:21 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-01-21 09:05:43 PST 
Although keyring is certainly useful so a contributor does not have to constantly input their password, it's not needed for the library the function. We should effectively make it an optional import.
Comment 1 Radar WebKit Bug Importer 2021-01-21 09:05:59 PST 
<rdar://problem/73454666>
Comment 2 Jonathan Bedard 2021-01-21 09:21:45 PST 
Created attachment 418047 [details]
Patch
Comment 3 EWS 2021-01-21 09:54:59 PST 
Committed r271697: <https://trac.webkit.org/changeset/271697>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418047 [details].