Bug 220744 - [webkitcorepy] Support alternative default pypi url on macOS
Summary: [webkitcorepy] Support alternative default pypi url on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 220736
  Show dependency tree / graph
 
Reported: 2021-01-19 13:00 PST by Jonathan Bedard
Modified: 2021-01-20 08:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2021-01-19 13:52 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (3.14 KB, patch)
2021-01-19 15:50 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.37 KB, patch)
2021-01-20 08:01 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-01-19 13:00:29 PST 
A bit of a niche use-case for some of Apple's automated infrastructure.
Comment 1 Radar WebKit Bug Importer 2021-01-19 13:02:12 PST 
<rdar://problem/73369338>
Comment 2 Jonathan Bedard 2021-01-19 13:52:26 PST 
Created attachment 417908 [details]
Patch
Comment 3 Aakash Jain 2021-01-19 15:28:19 PST 
Comment on attachment 417908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417908&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:320
> +                parts = line.split('/')

is it reliable way to depend on the line containing certain number of slashes. Can we explicitly read index/index-url from the file?
Comment 4 Aakash Jain 2021-01-19 15:29:18 PST 
maybe using a regex starting with https://
Comment 5 Jonathan Bedard 2021-01-19 15:36:16 PST 
(In reply to Aakash Jain from comment #4)
> maybe using a regex starting with https://

Will replace this with a regex.
Comment 6 Jonathan Bedard 2021-01-19 15:50:24 PST 
Created attachment 417919 [details]
Patch for landing
Comment 7 EWS 2021-01-19 16:34:49 PST 
Committed r271630: <https://trac.webkit.org/changeset/271630>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417919 [details].
Comment 8 Jonathan Bedard 2021-01-20 08:01:50 PST 
Reopening to attach new patch.
Comment 9 Jonathan Bedard 2021-01-20 08:01:51 PST 
Created attachment 417969 [details]
Patch for landing
Comment 10 Jonathan Bedard 2021-01-20 08:03:01 PST 
Committed r271649: <https://trac.webkit.org/changeset/271649>