Bug 220731 - Web Inspector: `Historical Figures` string should be `Alternate Glyphs`
Summary: Web Inspector: `Historical Figures` string should be `Alternate Glyphs`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-19 08:10 PST by Patrick Angle
Modified: 2021-01-19 13:26 PST (History)
6 users (show)

See Also:

Attachments
Patch v1.0 (4.71 KB, patch)
2021-01-19 08:27 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-01-19 08:10:33 PST 
`Historical Figures` is very similar to the value `Historical Forms`, which can cause confusion in localization. While Historical forms is the only valid value at this time, it will be more accurate and create less confusion to name this field `Alternate Glyphs`, which is a better analogue to the underlying `font-variant-alternates` property.
Comment 1 Patrick Angle 2021-01-19 08:27:12 PST 
Created attachment 417877 [details]
Patch v1.0
Comment 2 Patrick Angle 2021-01-19 08:41:07 PST 
<rdar://73206500>
Comment 3 BJ Burg 2021-01-19 10:07:28 PST 
Comment on attachment 417877 [details]
Patch v1.0

r=me
Comment 4 EWS 2021-01-19 10:10:04 PST 
commit-queue failed to commit attachment 417877 [details] to WebKit repository.
Comment 5 EWS 2021-01-19 10:30:46 PST 
commit-queue failed to commit attachment 417877 [details] to WebKit repository.
Comment 6 EWS 2021-01-19 13:26:46 PST 
Committed r271612: <https://trac.webkit.org/changeset/271612>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417877 [details].