Bug 220691 - [JSC] Add some more exception checks in globalFuncCopyDataProperties
Summary: [JSC] Add some more exception checks in globalFuncCopyDataProperties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-17 17:10 PST by Yusuke Suzuki
Modified: 2021-01-17 22:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.10 KB, patch)
2021-01-17 17:13 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-17 17:10:17 PST 
[JSC] Add some more scope checks in globalFuncCopyDataProperties
Comment 1 Yusuke Suzuki 2021-01-17 17:13:47 PST 
Created attachment 417786 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-17 17:14:43 PST 
<rdar://problem/73242251>
Comment 3 Mark Lam 2021-01-17 21:56:50 PST 
Comment on attachment 417786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review

r=me with suggested title change.

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Add some more scope checks in globalFuncCopyDataProperties

I think "exception checks" would be more accurate than "scope checks".
Comment 4 Yusuke Suzuki 2021-01-17 22:01:17 PST 
Comment on attachment 417786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] Add some more scope checks in globalFuncCopyDataProperties
> 
> I think "exception checks" would be more accurate than "scope checks".

Thanks! Fixed.
Comment 5 Yusuke Suzuki 2021-01-17 22:03:38 PST 
Committed r271568: <https://trac.webkit.org/changeset/271568>