Bug 220472 - [Mac] Netflix controls do not fade out after entering fullscreen
Summary: [Mac] Netflix controls do not fade out after entering fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-08 12:04 PST by Jer Noble
Modified: 2021-01-20 11:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.69 KB, patch)
2021-01-08 12:09 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.39 KB, patch)
2021-01-13 16:54 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (11.44 KB, patch)
2021-01-20 10:28 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-01-08 12:04:05 PST 
[Mac] Netflix controls do not fade out after entering fullscreen
Comment 1 Jer Noble 2021-01-08 12:04:41 PST 
<rdar://70602577>
Comment 2 Jer Noble 2021-01-08 12:09:10 PST 
Created attachment 417289 [details]
Patch
Comment 3 Jer Noble 2021-01-13 16:54:07 PST 
Created attachment 417583 [details]
Patch
Comment 4 Eric Carlson 2021-01-13 17:38:16 PST 
Comment on attachment 417583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417583&action=review

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:401
> +        // FIXME(53342): remove once pointer events fire when elements move out from under the pointer.

2011!

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:408
> +            eventNumber:0 clickCount:0 pressure:0];

Nit: is there any reason to not put these an separate lines like the others?
Comment 5 Jer Noble 2021-01-13 21:29:51 PST 
(In reply to Eric Carlson from comment #4)
> Comment on attachment 417583 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417583&action=review
> 
> > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:401
> > +        // FIXME(53342): remove once pointer events fire when elements move out from under the pointer.
> 
> 2011!

Yeah. :-/

> > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:408
> > +            eventNumber:0 clickCount:0 pressure:0];
> 
> Nit: is there any reason to not put these an separate lines like the others?

Not really; it's a bit of copy-pasta.
Comment 6 Jer Noble 2021-01-20 10:28:55 PST 
Created attachment 417980 [details]
Patch for landing
Comment 7 EWS 2021-01-20 11:02:01 PST 
Committed r271656: <https://trac.webkit.org/changeset/271656>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417980 [details].