Bug 220411 - PaintFrameForMedia has a null identifier when media player is a media stream track video player
Summary: PaintFrameForMedia has a null identifier when media player is a media stream ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-07 06:35 PST by youenn fablet
Modified: 2021-01-08 07:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.90 KB, patch)
2021-01-07 06:55 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Reuploading to run on bots (8.84 KB, patch)
2021-01-08 02:51 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-01-07 06:35:40 PST 
PaintFrameForMedia has a null identifier when media player is a media stream track video player
Comment 1 Radar WebKit Bug Importer 2021-01-07 06:52:58 PST 
<rdar://problem/72888461>
Comment 2 youenn fablet 2021-01-07 06:55:06 PST 
Created attachment 417176 [details]
Patch
Comment 3 Wenson Hsieh 2021-01-07 10:03:54 PST 
Comment on attachment 417176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review

> Source/WebCore/platform/graphics/GraphicsContextImpl.h:108
> +    virtual bool canPaintFrameForMedia(const MediaPlayer&) const = 0;

I think you'll need to update this method for other platforms as well (i.e. Windows, Cairo, Nicosia).
Comment 4 Wenson Hsieh 2021-01-07 10:04:36 PST 
Comment on attachment 417176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review

> Source/WebCore/ChangeLog:12
> +        Covered by test in gu process mode.

Nit - "gu" => "GPU"
Comment 5 youenn fablet 2021-01-08 02:51:53 PST 
Created attachment 417259 [details]
Reuploading to run on bots
Comment 6 EWS 2021-01-08 07:26:40 PST 
Committed r271295: <https://trac.webkit.org/changeset/271295>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417259 [details].