Bug 220315 - build-webkit compilation error on macOS Catalina 10.15.7
Summary: build-webkit compilation error on macOS Catalina 10.15.7
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified macOS 10.15
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-05 02:35 PST by Dario D'Amico
Modified: 2021-01-12 02:36 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dario D'Amico 2021-01-05 02:35:06 PST 
WebKit does not build on macOS Catalina 10.15.7 because of a compilation error in the Metal Angle renderer.

    /Users/dari8942/Desktop/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm:530:17: error: 
       'setPreserveInvariance:' is only available on macOS 11.0 or newer
       [-Werror,-Wunguarded-availability-new]
        options.preserveInvariance = true;
            ^~~~~~~~~~~~~~~~~~

User ap on the Slack WebKit channel suggested to change MAX_ALLOWED to MIN_REQUIRED in the preprocessor conditions that guard the compilation of that line.

It seems like that does the trick because I tried in my local repo and it gets rid of the error; however the build still fails for some other reason that I am investigating. 

In short, there seems to be a similar 10.15 vs 11.0 problem that affects Cocoa/AVAssetWriterSPI.h. Not sure whether I should create a separate bug report or just keep adding to this as I discover new compilation errors.
Comment 1 Alexey Proskuryakov 2021-01-05 08:53:48 PST 
It's OK to fix all of these at once as long as it's all just version checks and ifdefs, and no deep changes that would require expert review.
Comment 2 Radar WebKit Bug Importer 2021-01-12 02:36:14 PST 
<rdar://problem/73033480>