Bug 220135 - [LFC][Integration] Use the pre-computed geometries for the inline level boxes
Summary: [LFC][Integration] Use the pre-computed geometries for the inline level boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-23 20:40 PST by zalan
Modified: 2020-12-25 13:46 PST (History)
11 users (show)

See Also:

Attachments
Patch (11.60 KB, patch)
2020-12-23 20:44 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.81 KB, patch)
2020-12-23 21:13 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.68 KB, patch)
2020-12-25 12:15 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-12-23 20:40:12 PST 
instead of looping through the inline content and computed them all over again.
Comment 1 Radar WebKit Bug Importer 2020-12-23 20:40:32 PST 
<rdar://problem/72642850>
Comment 2 zalan 2020-12-23 20:44:16 PST 
Created attachment 416736 [details]
Patch
Comment 3 zalan 2020-12-23 21:13:45 PST 
Created attachment 416737 [details]
Patch
Comment 4 Antti Koivisto 2020-12-25 08:38:07 PST 
Comment on attachment 416737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416737&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70
> +    // For integration only.
> +    void collectInlineContentIfNeeded();
> +    void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&);

Saying that these are "intergration only" is bit misleading since they are used internally in any case. They are just public for integration.

Maybe these could stay private and there could be public 'lineLayoutForIntergration' or similar that calls them?
Comment 5 zalan 2020-12-25 11:30:57 PST 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 416737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416737&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70
> > +    // For integration only.
> > +    void collectInlineContentIfNeeded();
> > +    void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&);
> 
> Saying that these are "intergration only" is bit misleading since they are
> used internally in any case. They are just public for integration.
> 
> Maybe these could stay private and there could be public
> 'lineLayoutForIntergration' or similar that calls them?
Yeah, I like that.
Comment 6 zalan 2020-12-25 12:15:43 PST 
Created attachment 416757 [details]
Patch
Comment 7 EWS 2020-12-25 13:46:40 PST 
Committed r271085: <https://trac.webkit.org/changeset/271085>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416757 [details].