Bug 220058 - Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons
Summary: Unmuting a track in case of end of interruption by another web process tab is...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 220591
Blocks:
  Show dependency tree / graph
 
Reported: 2020-12-21 09:23 PST by youenn fablet
Modified: 2021-01-13 07:52 PST (History)
14 users (show)

See Also:

Attachments
Patch (16.09 KB, patch)
2020-12-21 09:58 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (20.33 KB, patch)
2021-01-05 05:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (19.73 KB, patch)
2021-01-12 05:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-12-21 09:23:32 PST 
Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons
Comment 1 youenn fablet 2020-12-21 09:58:05 PST 
Created attachment 416606 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-12-28 09:24:12 PST 
<rdar://problem/72705675>
Comment 3 youenn fablet 2021-01-05 05:48:53 PST 
Created attachment 416998 [details]
Patch
Comment 4 Eric Carlson 2021-01-11 14:25:06 PST 
Comment on attachment 416998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416998&action=review

> Source/WebCore/ChangeLog:20
> +        When an interruption ends, all capture tracks are updated accorsing the page muted state, which is controlled by UIProcess.

s/updated accorsing the page/updated according to the page/

> Source/WebKit/ChangeLog:172
> -2020-12-22  Youenn Fablet  <youenn@apple.com>
> +2020-12-21  Youenn Fablet  <youenn@apple.com>

Is this change intentional?

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:487
> +        // We can only have one source at a time: we can mute all tracks but unmute only one of them.

Nit: this and the comment below are duplicated in the audio and video loops, they could be moved up above instead.
Comment 5 youenn fablet 2021-01-12 05:09:55 PST 
Created attachment 417445 [details]
Patch for landing
Comment 6 EWS 2021-01-12 06:34:33 PST 
Committed r271401: <https://trac.webkit.org/changeset/271401>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417445 [details].
Comment 7 WebKit Commit Bot 2021-01-13 07:52:01 PST 
Re-opened since this is blocked by bug 220591