Bug 220040 - [LFC] Move content height logic to the formatting contexts.
Summary: [LFC] Move content height logic to the formatting contexts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-19 14:38 PST by zalan
Modified: 2020-12-20 07:12 PST (History)
5 users (show)

See Also:

Attachments
Patch (19.50 KB, patch)
2020-12-19 15:50 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-12-19 14:38:46 PST 
Let's make the FCs compute their content heights.
Comment 1 zalan 2020-12-19 15:50:37 PST 
Created attachment 416576 [details]
Patch
Comment 2 zalan 2020-12-19 15:52:01 PST 
So this patch has a const_cast and I am curious of how to avoid that (other than making the contentHeight() functions static).
Comment 3 Simon Fraser (smfr) 2020-12-19 18:12:02 PST 
Comment on attachment 416576 [details]
Patch

Very nice.
Comment 4 EWS 2020-12-20 07:11:34 PST 
Committed r271012: <https://trac.webkit.org/changeset/271012>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416576 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-20 07:12:22 PST 
<rdar://problem/72518413>