Bug 220015 - Add test for logical properties in webkit non-standard '-webkit-writing-mode: horizontal-bt' mode
Summary: Add test for logical properties in webkit non-standard '-webkit-writing-mode:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-18 09:04 PST by zsun
Modified: 2020-12-22 04:44 PST (History)
9 users (show)

See Also:

Attachments
Patch (34.89 KB, patch)
2020-12-22 02:20 PST, zsun 		no flags Details | Formatted Diff | Diff
Patch (34.89 KB, patch)
2020-12-22 02:28 PST, zsun 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2020-12-18 09:04:10 PST 
Add tests to check if logical properties work well in webkit non-standard '-webkit-writing-mode: horizontal-bt' mode
Comment 1 zsun 2020-12-22 02:20:00 PST 
Created attachment 416656 [details]
Patch
Comment 2 EWS Watchlist 2020-12-22 02:21:10 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 zsun 2020-12-22 02:28:24 PST 
Created attachment 416658 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2020-12-22 03:55:35 PST 
Comment on attachment 416658 [details]
Patch

The changes look good, but you need to export them to WPT and merge there first, before merging them here.
Comment 5 Manuel Rego Casasnovas 2020-12-22 04:33:14 PST 
Comment on attachment 416658 [details]
Patch

The WPT has been merged so this is ready to be merged too: https://github.com/web-platform-tests/wpt/pull/26987
Comment 6 EWS 2020-12-22 04:43:03 PST 
Committed r271051: <https://trac.webkit.org/changeset/271051>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416658 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-22 04:44:15 PST 
<rdar://problem/72583838>