Bug 219992 - [webkitscmpy] Correct mock `git log` call in standard git repositories
Summary: [webkitscmpy] Correct mock `git log` call in standard git repositories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-17 12:26 PST by Jonathan Bedard
Modified: 2020-12-17 15:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.18 KB, patch)
2020-12-17 12:31 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (5.18 KB, patch)
2020-12-17 12:53 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (5.17 KB, patch)
2020-12-17 14:39 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-17 12:26:57 PST 
Operator precedence makes it so that our mock `git log` command returns an empty log when the mock repository is not a git-svn repository.
Comment 1 Radar WebKit Bug Importer 2020-12-17 12:27:18 PST 
<rdar://problem/72436380>
Comment 2 Jonathan Bedard 2020-12-17 12:31:03 PST 
Created attachment 416450 [details]
Patch
Comment 3 Jonathan Bedard 2020-12-17 12:53:43 PST 
Created attachment 416457 [details]
Patch
Comment 4 dewei_zhu 2020-12-17 13:06:23 PST 
r=me
Comment 5 Jonathan Bedard 2020-12-17 14:39:14 PST 
Created attachment 416471 [details]
Patch for landing
Comment 6 EWS 2020-12-17 15:30:45 PST 
Committed r270956: <https://trac.webkit.org/changeset/270956>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416471 [details].