Bug 219962 - [LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
Summary: [LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-16 15:04 PST by zalan
Modified: 2020-12-19 05:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.72 KB, patch)
2020-12-16 15:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.50 KB, patch)
2020-12-16 19:49 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.52 KB, patch)
2020-12-16 20:23 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2020-12-17 10:11 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.02 KB, patch)
2020-12-18 21:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-12-16 15:04:56 PST 
ssia
Comment 1 zalan 2020-12-16 15:35:49 PST 
Created attachment 416366 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-12-16 15:37:43 PST 
<rdar://problem/72402622>
Comment 3 zalan 2020-12-16 19:49:45 PST 
Created attachment 416382 [details]
Patch
Comment 4 zalan 2020-12-16 20:23:08 PST 
Created attachment 416385 [details]
Patch
Comment 5 Antti Koivisto 2020-12-16 23:27:08 PST 
Comment on attachment 416385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416385&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:345
> -void LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically(LineBox& lineBox)
> +void LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically(LineBox& lineBox)

The important fix!
Comment 6 zalan 2020-12-17 10:11:35 PST 
Created attachment 416435 [details]
Patch
Comment 7 zalan 2020-12-18 21:27:49 PST 
Created attachment 416567 [details]
Patch
Comment 8 EWS 2020-12-19 05:16:28 PST 
Committed r271002: <https://trac.webkit.org/changeset/271002>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416567 [details].