Bug 219875 - [macOS] Adjust date input placeholder color based on specified text color
Summary: [macOS] Adjust date input placeholder color based on specified text color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-14 15:00 PST by Aditya Keerthi
Modified: 2020-12-15 17:05 PST (History)
12 users (show)

See Also:

Attachments
Patch (19.63 KB, patch)
2020-12-14 15:03 PST, Aditya Keerthi 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (20.36 KB, patch)
2020-12-15 13:29 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-12-14 15:00:12 PST 
...
Comment 1 Aditya Keerthi 2020-12-14 15:00:29 PST 
<rdar://problem/72314705>
Comment 2 Aditya Keerthi 2020-12-14 15:03:56 PST 
Created attachment 416197 [details]
Patch
Comment 3 Darin Adler 2020-12-15 11:50:57 PST 
Comment on attachment 416197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416197&action=review

Really great changes!

> LayoutTests/ChangeLog:12
> +        * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added.

It’s a little disappointing when we can only create a mismatch test, since there are so many ways for such tests to pass (false negative).

Can we make a reference test, carefully choosing colors so the placeholder text can be reproduced with some other mechanism. Or is that impractical?
Comment 4 Aditya Keerthi 2020-12-15 13:29:44 PST 
Created attachment 416287 [details]
Patch for landing
Comment 5 Aditya Keerthi 2020-12-15 13:32:59 PST 
(In reply to Darin Adler from comment #3)
> Comment on attachment 416197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416197&action=review
> 
> Really great changes!

Thanks for the review!

> > LayoutTests/ChangeLog:12
> > +        * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added.
> 
> It’s a little disappointing when we can only create a mismatch test, since
> there are so many ways for such tests to pass (false negative).
> 
> Can we make a reference test, carefully choosing colors so the placeholder
> text can be reproduced with some other mechanism. Or is that impractical?

I removed the mismatch test and replaced it with a reference test that reproduces the placeholder text by setting the value of the input to the current date, and styling the day/month/year fields.
Comment 6 EWS 2020-12-15 17:05:45 PST 
Committed r270875: <https://trac.webkit.org/changeset/270875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416287 [details].