Bug 219869 - Add webkit- prefix to SpeechRecognition
Summary: Add webkit- prefix to SpeechRecognition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-14 12:08 PST by Sihui Liu
Modified: 2020-12-15 15:05 PST (History)
14 users (show)

See Also:

Attachments
Patch (14.55 KB, patch)
2020-12-14 12:14 PST, Sihui Liu 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (38.73 KB, patch)
2020-12-14 16:19 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
WIP (30.50 KB, patch)
2020-12-14 16:24 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (33.37 KB, patch)
2020-12-14 21:49 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (33.42 KB, patch)
2020-12-15 14:16 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-12-14 12:08:02 PST 
...
Comment 1 Sihui Liu 2020-12-14 12:14:11 PST 
Created attachment 416182 [details]
Patch
Comment 2 Sihui Liu 2020-12-14 16:19:59 PST 
Created attachment 416205 [details]
Patch
Comment 3 Sihui Liu 2020-12-14 16:24:15 PST 
Created attachment 416207 [details]
WIP
Comment 4 Sihui Liu 2020-12-14 21:49:26 PST 
Created attachment 416224 [details]
Patch
Comment 5 youenn fablet 2020-12-15 00:26:36 PST 
Comment on attachment 416224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416224&action=review

> Source/WebCore/Modules/speech/SpeechRecognition.idl:29
> +    InterfaceName=webkitSpeechRecognition,

I think we might want to have both webkitSpeechRecognition and SpeechRecognition be defined.
I would add a separate setting to enable this prefixed version as well, like done for web audio.
Comment 6 Sihui Liu 2020-12-15 12:00:28 PST 
(In reply to youenn fablet from comment #5)
> Comment on attachment 416224 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416224&action=review
> 
> > Source/WebCore/Modules/speech/SpeechRecognition.idl:29
> > +    InterfaceName=webkitSpeechRecognition,
> 
> I think we might want to have both webkitSpeechRecognition and
> SpeechRecognition be defined.
> I would add a separate setting to enable this prefixed version as well, like
> done for web audio.

Per discussion on Slack, I guess we are Okay with only prefix version first.
Comment 7 Geoffrey Garen 2020-12-15 13:11:37 PST 
Comment on attachment 416224 [details]
Patch

r=me
Comment 8 EWS 2020-12-15 13:50:07 PST 
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 9 Sihui Liu 2020-12-15 14:16:33 PST 
Created attachment 416292 [details]
Patch for landing
Comment 10 EWS 2020-12-15 15:04:49 PST 
Committed r270868: <https://trac.webkit.org/changeset/270868>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416292 [details].
Comment 11 Radar WebKit Bug Importer 2020-12-15 15:05:20 PST 
<rdar://problem/72359735>