Bug 219865 - [GLIB] Missing header for std::once_flag in WebKitInitialize.cpp
Summary: [GLIB] Missing header for std::once_flag in WebKitInitialize.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Linux
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-14 11:29 PST by Pablo Saavedra
Modified: 2020-12-14 12:18 PST (History)
6 users (show)

See Also:

Attachments
patch (1.16 KB, patch)
2020-12-14 11:31 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2020-12-14 11:29:11 PST 
Error:


../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp: In function �~@~Xvoid WebKit::webkitInitialize()�~@~Y:
../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:61:17: error: �~@~Xonce_flag�~@~Y in namespace �~@~Xstd�~@~Y does not name a type
   61 |     static std::once_flag onceFlag;
      |                 ^~~~~~~~~
../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:32:1: note: �~@~Xstd::once_flag�~@~Y is defined in header �~@~X<mutex>�~@~Y; did you forget to �~@~X#include <mutex>�~@~Y?
   31 | #include <wtf/glib/GUniquePtr.h>
  +++ |+#include <mutex>
   32 |
Comment 1 Pablo Saavedra 2020-12-14 11:31:50 PST 
Created attachment 416178 [details]
patch
Comment 2 EWS Watchlist 2020-12-14 11:32:57 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-12-14 12:18:38 PST 
Committed r270797: <https://trac.webkit.org/changeset/270797>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416178 [details].