Bug 219669 - WebGL context screen change events should work with GPU process
Summary: WebGL context screen change events should work with GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
: 219349 220806 (view as bug list)
Depends on: 223121
Blocks: webglgpup
  Show dependency tree / graph
 
Reported: 2020-12-08 23:06 PST by Kimmo Kinnunen
Modified: 2021-03-12 07:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.51 KB, patch)
2021-03-04 03:49 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (14.82 KB, patch)
2021-03-04 05:43 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (14.79 KB, patch)
2021-03-05 04:27 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (14.69 KB, patch)
2021-03-07 23:10 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2020-12-08 23:06:51 PST 
WebGL context screen change events should work with GPU process
Comment 1 Radar WebKit Bug Importer 2020-12-15 23:07:15 PST 
<rdar://problem/72373371>
Comment 2 Kimmo Kinnunen 2021-03-04 03:49:39 PST 
Created attachment 422213 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-03-04 05:43:02 PST 
Created attachment 422217 [details]
Patch
Comment 4 Jon Lee 2021-03-04 09:57:35 PST 
*** Bug 220806 has been marked as a duplicate of this bug. ***
Comment 5 Kimmo Kinnunen 2021-03-04 12:06:49 PST 
*** Bug 219349 has been marked as a duplicate of this bug. ***
Comment 6 Per Arne Vollan 2021-03-04 12:53:22 PST 
Comment on attachment 422217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422217&action=review

R=me.

> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:102
> +        protectedThis->m_context->displayWasReconfigured();

Will this be thread safe?
Comment 7 Kimmo Kinnunen 2021-03-04 23:27:23 PST 
(In reply to Per Arne Vollan from comment #6)
> > Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:102
> > +        protectedThis->m_context->displayWasReconfigured();
> 
> Will this be thread safe?

Yes, the m_context parts are the parts that get run in the work queue.
Comment 8 Kimmo Kinnunen 2021-03-05 04:27:56 PST 
Created attachment 422363 [details]
Patch
Comment 9 Kimmo Kinnunen 2021-03-07 23:10:58 PST 
Created attachment 422545 [details]
Patch
Comment 10 EWS 2021-03-08 01:37:31 PST 
Committed r274065: <https://commits.webkit.org/r274065>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422545 [details].