219610 – REGRESSION (r270507): ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) under WebCore::RTCRtpSFrameTransformer::updateEncryptionKey

Bug 219610 - REGRESSION (r270507): ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) under WebCore::RTCRtpSFrameTransformer::updateEncryptionKey

Summary: REGRESSION (r270507): ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emp...

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebRTC (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-12-07 12:38 PST by Ryan Haddad
Modified:	2020-12-07 12:59 PST (History)
CC List:	3 users (show)

See Also:	219598

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryan Haddad 2020-12-07 12:38:50 PST

TestWebKitAPI.RTCRtpSFrameTransformer.EncryptDecryptKeyID0
        ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
        /Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/usr/local/include/wtf/HashTable.h(649) : void WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::checkKey(const T &) [Key = unsigned long long, Value = WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >, HashFunctions = WTF::DefaultHash<unsigned long long>, Traits = WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, KeyTraits = WTF::HashTraits<unsigned long long>, HashTranslator = WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, T = unsigned long long]
        1   0x1047d8cc9 WTFCrash
        2   0x121c1720b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x123e7a0ab void WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::checkKey<WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, unsigned long long>(unsigned long long const&)
        4   0x123e79d3f WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::add<WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
        5   0x123e79cc4 WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::inlineAdd<unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
        6   0x123e79c08 WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::inlineSet<unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
        7   0x123e4ab9f WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::set<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
        8   0x123e4a930 WebCore::RTCRtpSFrameTransformer::updateEncryptionKey(WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Optional<unsigned long long>, WebCore::RTCRtpSFrameTransformer::ShouldUpdateKeys)
        9   0x123e4917d WebCore::RTCRtpSFrameTransformer::setEncryptionKey(WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Optional<unsigned long long>)
        10  0x1025ce8b3 TestWebKitAPI::RTCRtpSFrameTransformer_EncryptDecryptKeyID0_Test::TestBody()
        11  0x102a22af4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        12  0x1029f12bb void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        13  0x1029f11f6 testing::Test::Run()
        14  0x1029f238a testing::TestInfo::Run()
        15  0x1029f3274 testing::TestCase::Run()
        16  0x1029fe928 testing::internal::UnitTestImpl::RunAllTests()
        17  0x102a27af4 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        18  0x1029fe41b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        19  0x1029fe2ed testing::UnitTest::Run()
        20  0x1027ae971 RUN_ALL_TESTS()
        21  0x1027ae902 TestWebKitAPI::TestsController::run(int, char**)
        22  0x1029bc0b5 main
        23  0x7fff6d82fcc9 start
        24  0x2

https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/8095/steps/run-api-tests/logs/stdio

Comment 1 Ryan Haddad 2020-12-07 12:40:26 PST

I think this regressed with https://trac.webkit.org/changeset/270507/webkit

Comment 2 Radar WebKit Bug Importer 2020-12-07 12:40:41 PST

<rdar://problem/72059408>

Comment 3 youenn fablet 2020-12-07 12:42:58 PST

Oh right, we should revert the change.

Comment 4 Ryan Haddad 2020-12-07 12:47:39 PST

Also affected these tests:
http/wpt/webrtc/sframe-transform.html
webrtc/audio-sframe.html
webrtc/sframe-keys.html
webrtc/video-sframe.html

Comment 5 Ryan Haddad 2020-12-07 12:49:12 PST

Reverted in https://trac.webkit.org/changeset/270518

Comment 6 youenn fablet 2020-12-07 12:59:55 PST

Thanks