Bug 219384 - [WK1] Only the first wheel event in a gesture should be cancelable
Summary: [WK1] Only the first wheel event in a gesture should be cancelable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 218764
  Show dependency tree / graph
 
Reported: 2020-11-30 21:14 PST by Simon Fraser (smfr)
Modified: 2020-12-01 10:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (17.34 KB, patch)
2020-11-30 21:18 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.31 KB, patch)
2020-11-30 21:28 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (17.32 KB, patch)
2020-11-30 22:55 PST, Simon Fraser (smfr) 		cdumez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-11-30 21:14:40 PST 
[WK1] Only the first wheel event in a gesture should be cancelable
Comment 1 Simon Fraser (smfr) 2020-11-30 21:18:50 PST 
Created attachment 415095 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-11-30 21:19:21 PST 
<rdar://problem/71836485>
Comment 3 Simon Fraser (smfr) 2020-11-30 21:28:35 PST 
Created attachment 415096 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-11-30 22:55:10 PST 
Created attachment 415100 [details]
Patch
Comment 5 Chris Dumez 2020-12-01 09:52:09 PST 
Comment on attachment 415100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415100&action=review

> LayoutTests/fast/events/wheel/first-wheel-event-cancelable.html:44
> +            debug('Tests preventDefault on the first event results in the rest of the events being cancelable')

description() would likely look better than debug().

> LayoutTests/fast/events/wheel/wheel-events-become-non-cancelable.html:55
> +            debug('Tests that events in the gesture are non-cancelable if preventDefault was not called on the first event');

ditto.
Comment 6 Simon Fraser (smfr) 2020-12-01 10:02:17 PST 
https://trac.webkit.org/r270312