Bug 219364 - [build.webkit.org] Move old buildbot unittests to steps_unittest_old.py
Summary: [build.webkit.org] Move old buildbot unittests to steps_unittest_old.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency tree / graph
 
Reported: 2020-11-30 11:45 PST by Aakash Jain
Modified: 2021-08-19 16:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (117.75 KB, patch)
2020-11-30 11:51 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-30 11:45:17 PST 
Unit tests are significantly different for old Buildbot (Buildbot 0.8) and newer Buildbot.

We should move old buildbot unittests to steps_unittest_old.py. Adding new buildbot unit tests in
Comment 1 Aakash Jain 2020-11-30 11:51:27 PST 
Created attachment 415039 [details]
Patch
Comment 2 Aakash Jain 2020-11-30 12:08:05 PST 
Adding new buildbot unit tests in Bug 219363.
Comment 3 Jonathan Bedard 2020-11-30 13:22:50 PST 
(In reply to Aakash Jain from comment #1)
> Created attachment 415039 [details]
> Patch

Aakash noted in Slack that once this lands, we will need a buildbot restart.
Comment 4 EWS 2020-11-30 13:46:01 PST 
Committed r270262: <https://trac.webkit.org/changeset/270262>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415039 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-30 13:47:27 PST 
<rdar://problem/71821157>
Comment 6 Aakash Jain 2020-11-30 14:20:48 PST 
Restarted buildbot to pick up this change.

Working fine, e.g.: https://ews-build.webkit.org/#/builders/20/builds/35540