Bug 219361 - Allow blob URLs with fragments
Summary: Allow blob URLs with fragments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-30 11:03 PST by Alex Christensen
Modified: 2020-11-30 15:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.84 KB, patch)
2020-11-30 11:05 PST, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (7.60 KB, patch)
2020-11-30 12:31 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-11-30 11:03:38 PST 
Allow blob URLs with fragments
Comment 1 Alex Christensen 2020-11-30 11:05:54 PST 
Created attachment 415035 [details]
Patch
Comment 2 Alex Christensen 2020-11-30 12:31:03 PST 
Created attachment 415042 [details]
Patch
Comment 3 EWS 2020-11-30 15:15:33 PST 
Committed r270269: <https://trac.webkit.org/changeset/270269>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415042 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-30 15:16:25 PST 
<rdar://problem/71825595>
Comment 5 Darin Adler 2020-11-30 15:17:21 PST 
Comment on attachment 415042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415042&action=review

> Source/WebCore/platform/network/BlobRegistryImpl.cpp:228
> +    if (url.hasFragmentIdentifier())
> +        return m_blobs.get(url.stringWithoutFragmentIdentifier().toStringWithoutCopying());
>      return m_blobs.get(url.string());

We should consider adding a version of toStringWithoutCopying that takes a WTF::String that is used if it happens to exactly match. Then we would not need an if statement, and could retain the "no string allocation/deallocation" optimization.