Bug 219355 - [GStreamer] SleepDisabler leaked when closing tab
Summary: [GStreamer] SleepDisabler leaked when closing tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-11-30 06:51 PST by Michael Catanzaro
Modified: 2021-06-28 10:16 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-11-30 06:51:51 PST 
Add some WTFLogAlways() debug to the SleepDisabler constructor and destructor to see when it is created and destroyed. Start playing a YouTube video and note that a SleepDisabler is created. Then close the browser tab. Notice that the destructor never runs: the SleepDisabler has somehow been leaked.

This might be a media bug, or it might be a higher-level bug if some other code is leaking the entire media player (hopefully not?). I'm not sure what is happening.
Comment 1 Philippe Normand 2021-06-28 01:52:48 PDT 
I can't reproduce this after fixing bug 219353.
Comment 2 Michael Catanzaro 2021-06-28 07:11:46 PDT 
I can no longer reproduce this, so I'll close this. But see also bug #219354.
Comment 3 Michael Catanzaro 2021-06-28 10:16:36 PDT 
After more testing, I'm fairly confident this is reliably fixed.