Bug 219319 - Remove enums for GCGLenum constants in GraphicsContextGL and ExtensionsGL
Summary: Remove enums for GCGLenum constants in GraphicsContextGL and ExtensionsGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-27 12:19 PST by Don Olmstead
Modified: 2020-11-28 06:42 PST (History)
12 users (show)

See Also:


Attachments
Patch (74.73 KB, patch)
2020-11-27 13:02 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-11-27 12:19:30 PST
When compiling with clang-cl the WinCairo build fails with

..\..\Source\WebCore\html\canvas\WebGLDrawBuffers.cpp(77,29): error: non-constant-expression cannot be narrowed from type 'WebCore::GraphicsContextGL::(anonymous enum at ..\..\Source\WebCore\platform\graphics\GraphicsContextGL.h:64:5)' to 'GCGLenum' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
        GCGLenum value[1] { (bufs[0] == GraphicsContextGL::BACK) ? GraphicsContextGL::COLOR_ATTACHMENT0 : GraphicsContextGL::NONE };
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
..\..\Source\WebCore\html\canvas\WebGLDrawBuffers.cpp(77,29): note: insert an explicit cast to silence this issue
        GCGLenum value[1] { (bufs[0] == GraphicsContextGL::BACK) ? GraphicsContextGL::COLOR_ATTACHMENT0 : GraphicsContextGL::NONE };
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                            static_cast<GCGLenum>(                                                                               )
Comment 1 Don Olmstead 2020-11-27 13:02:16 PST
Created attachment 414968 [details]
Patch
Comment 2 EWS 2020-11-28 06:41:18 PST
Committed r270218: <https://trac.webkit.org/changeset/270218>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414968 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-28 06:42:18 PST
<rdar://problem/71774248>