Bug 219262 - Introduce new display list meta commands in preparation for webkit.org/b/219091
Summary: Introduce new display list meta commands in preparation for webkit.org/b/219091
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 219091
  Show dependency tree / graph
 
Reported: 2020-11-23 11:22 PST by Wenson Hsieh
Modified: 2020-11-27 12:09 PST (History)
8 users (show)

See Also:

Attachments
Patch (19.75 KB, patch)
2020-11-23 12:16 PST, Wenson Hsieh 		rniwa: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (25.65 KB, patch)
2020-11-24 12:39 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (25.64 KB, patch)
2020-11-24 12:42 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-11-23 11:22:24 PST 
More info in ChangeLog
Comment 1 Wenson Hsieh 2020-11-23 12:16:34 PST 
Created attachment 414811 [details]
Patch
Comment 2 Ryosuke Niwa 2020-11-23 12:30:53 PST 
Comment on attachment 414811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review

> Source/WebCore/ChangeLog:18
> +        `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items;

Why not just MetaCommandEnd. OfDisplayList seems redundant.
Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future.

> Source/WebCore/ChangeLog:24
> +        by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item.

Change we should rename this to MetaCommandChangeItemBuffer to be consistent
although this is really more like MetaCommandContinueInNewItemBuffer.
Comment 3 Wenson Hsieh 2020-11-23 12:56:26 PST 
Comment on attachment 414811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review

>> Source/WebCore/ChangeLog:18
>> +        `MetaCommandEndOfDisplayList` is used to inform the replayer that it should expect no more display list items;
> 
> Why not just MetaCommandEnd. OfDisplayList seems redundant.
> Or maybe MetaCommandPause or MetaCommandWait since we can receive more display list items in the future.

`MetaCommandEnd` sounds good to me — renamed to that.

>> Source/WebCore/ChangeLog:24
>> +        by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude with a `MetaCommandEndOfDisplayList` item.
> 
> Change we should rename this to MetaCommandChangeItemBuffer to be consistent
> although this is really more like MetaCommandContinueInNewItemBuffer.

Makes sense — I'll rename it to `MetaCommandChangeItemBuffer` in this patch for consistency with `MetaCommandChangeDestinationImageBuffer`.
Comment 4 Wenson Hsieh 2020-11-24 12:39:07 PST 
Created attachment 414848 [details]
Patch
Comment 5 Wenson Hsieh 2020-11-24 12:42:24 PST 
Created attachment 414849 [details]
Patch
Comment 6 EWS 2020-11-27 12:08:03 PST 
Committed r270203: <https://trac.webkit.org/changeset/270203>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414849 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-27 12:09:24 PST 
<rdar://problem/71767392>