Bug 219229 - REGRESSION: http/tests/inspector/network/resource-timing.html and http/tests/inspector/network/x-frame-options.html are flaky failures
Summary: REGRESSION: http/tests/inspector/network/resource-timing.html and http/tests/...
Status: RESOLVED DUPLICATE of bug 218830
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-20 15:57 PST by Ryan Haddad
Modified: 2020-11-20 16:49 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-11-20 15:57:02 PST 
http/tests/inspector/network/resource-timing.html and http/tests/inspector/network/x-frame-options.html have become flaky failures

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-timing-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/inspector/network/resource-timing-actual.txt
@@ -19,6 +19,7 @@
 PASS: responseEnd should come after responseStart.
 
 -- Running test case: Resource.TimingData.Redirect
+ERROR: Missing frame for given frameId
 PASS: Start time should be before redirect start time.
 PASS: Redirect start time should be before redirect end time.
 PASS: Redirect duration should be at least a few milliseconds.

--- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/inspector/network/x-frame-options-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/http/tests/inspector/network/x-frame-options-actual.txt
@@ -7,5 +7,6 @@
 PASS: X-Frame-Options headers should match.
 
 -- Running test case: Network.XFrameOptions.Sameorigin
+ERROR: Missing frame for given frameId
 PASS: X-Frame-Options headers should match.
 
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-timing.html&test=http%2Ftests%2Finspector%2Fnetwork%2Fx-frame-options.html
Comment 1 Ryan Haddad 2020-11-20 16:47:41 PST 
The first failure appears to be at https://trac.webkit.org/changeset/269439/webkit, which was a build fix for:

Store WeakPtr<Frame> instead of Frame*
​https://bugs.webkit.org/show_bug.cgi?id=218599

Seems like that could be related given the error messages in the test being about frames.
Comment 2 Radar WebKit Bug Importer 2020-11-20 16:47:53 PST 
<rdar://problem/71646591>
Comment 3 Alex Christensen 2020-11-20 16:48:56 PST 

*** This bug has been marked as a duplicate of bug 218830 ***
Comment 4 Ryan Haddad 2020-11-20 16:49:30 PST 
oops, thanks.