Bug 219207 - Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet
Summary: Remove DataDetectorType::None, it's not appropriate for a enum used as an Opt...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-20 09:15 PST by Sam Weinig
Modified: 2024-07-22 08:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2020-11-20 09:17 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2020-11-20 10:36 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-11-20 09:15:08 PST 
Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet
Comment 1 Sam Weinig 2020-11-20 09:17:08 PST 
Created attachment 414689 [details]
Patch
Comment 2 Anders Carlsson 2020-11-20 10:02:34 PST 
Comment on attachment 414689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414689&action=review

> Source/WebCore/page/Settings.yaml:97
> +      default: static_cast<DataDetectorType>(0)

Not sure how this is turned into C++ but I wonder if it's possible to make it be { } ?
Comment 3 Sam Weinig 2020-11-20 10:33:42 PST 
(In reply to Anders Carlsson from comment #2)
> Comment on attachment 414689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414689&action=review
> 
> > Source/WebCore/page/Settings.yaml:97
> > +      default: static_cast<DataDetectorType>(0)
> 
> Not sure how this is turned into C++ but I wonder if it's possible to make
> it be { } ?

Hm, not sure. Will experiment with that.
Comment 4 Sam Weinig 2020-11-20 10:34:49 PST 
Well, oops, looks like this breaks Debug tests due to an assert in OptionSet (which makes sense). Maybe { } will fair better.
Comment 5 Sam Weinig 2020-11-20 10:36:19 PST 
Created attachment 414696 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2020-11-27 09:16:13 PST 
<rdar://problem/71766018>
Comment 7 Ahmad Saleem 2024-07-22 05:08:46 PDT 
@Ryan - you landed this:

https://github.com/WebKit/WebKit/commit/8cf368ed3d211063f591761aaa24bf3d5e4deda3

After above, is this required? Or we can do further clean-up?
Comment 8 Ryan Reno 2024-07-22 08:46:27 PDT 
@Ahmad That patch was written by Richard Robinson.