Bug 219033 - StringBuilder append(const String& string) has a few redundant checks
Summary: StringBuilder append(const String& string) has a few redundant checks
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-17 07:27 PST by xc.o.c.1180@gmail.com
Modified: 2020-11-18 18:41 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch. (2.41 KB, patch)
2020-11-17 07:27 PST, xc.o.c.1180@gmail.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xc.o.c.1180@gmail.com 2020-11-17 07:27:42 PST 
Created attachment 414337 [details]
Proposed patch.

After 'if (!string.length())', string's StringImpl can not be null, a few null checks can be skipped by using StringImpl reference.

Please see patch for details.


Thanks.
Comment 1 Radar WebKit Bug Importer 2020-11-18 10:37:16 PST 
<rdar://problem/71545904>
Comment 2 Darin Adler 2020-11-18 18:41:20 PST 
Comment on attachment 414337 [details]
Proposed patch.

Yes, looks OK. Since it makes the code slightly less elegant, and I am not sure it will make things more efficient on any platform, I am not sure we should make the change.