Bug 219017 - REGRESSION (r269824): YouTube media control bar sometimes flickers
Summary: REGRESSION (r269824): YouTube media control bar sometimes flickers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-16 19:10 PST by Tim Horton
Modified: 2020-11-17 00:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.48 KB, patch)
2020-11-16 19:10 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2020-11-16 19:36 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-11-16 19:10:16 PST 
REGRESSION (r269824): YouTube media control bar sometimes flickers
Comment 1 Tim Horton 2020-11-16 19:10:45 PST 
Created attachment 414299 [details]
Patch
Comment 2 Tim Horton 2020-11-16 19:10:47 PST 
<rdar://problem/71454799>
Comment 3 Simon Fraser (smfr) 2020-11-16 19:20:53 PST 
Comment on attachment 414299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414299&action=review

> LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:4
> +  <style type="text/css" media="screen">

No need for `type="text/css" media="screen"`

> LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:9
> +        -webkit-transform: translateZ(0);

no prefix!

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:9
> +        -webkit-transform: translateZ(0);

No prefix.

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:25
> +            await UIHelper.ensurePresentationUpdate();

Maybe UIHelper.renderingUpdate()?

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:27
> +            await UIHelper.ensurePresentationUpdate();

Same
Comment 4 Tim Horton 2020-11-16 19:29:10 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 414299 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414299&action=review
> 
> > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:4
> > +  <style type="text/css" media="screen">
> 
> No need for `type="text/css" media="screen"`

Erk, I removed them from the other one (obviously I started with a really antique test).

> > LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:9
> > +        -webkit-transform: translateZ(0);
> 
> no prefix!

TRUE

> > LayoutTests/compositing/repaint/transparent-layer-repaint.html:9
> > +        -webkit-transform: translateZ(0);
> 
> No prefix.
> 
> > LayoutTests/compositing/repaint/transparent-layer-repaint.html:25
> > +            await UIHelper.ensurePresentationUpdate();
> 
> Maybe UIHelper.renderingUpdate()?

Whazzat. I'll look!

> > LayoutTests/compositing/repaint/transparent-layer-repaint.html:27
> > +            await UIHelper.ensurePresentationUpdate();
> 
> Same
Comment 5 Tim Horton 2020-11-16 19:36:38 PST 
Created attachment 414301 [details]
Patch
Comment 6 EWS 2020-11-17 00:28:53 PST 
Committed r269895: <https://trac.webkit.org/changeset/269895>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414301 [details].