Bug 218956 - TextEncoderStreamEncoder should not be exposed
Summary: TextEncoderStreamEncoder should not be exposed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-15 04:12 PST by youenn fablet
Modified: 2020-11-16 04:19 PST (History)
7 users (show)

See Also:

Attachments
Patch (20.39 KB, patch)
2020-11-15 04:31 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (20.28 KB, patch)
2020-11-15 09:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (15.58 KB, patch)
2020-11-16 00:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-11-15 04:12:37 PST 
As spotted by Yusuke, TextEncoderStreamEncoder should not be exposed, ditto for TextDecoderStreamDecoder
Comment 1 youenn fablet 2020-11-15 04:31:11 PST 
Created attachment 414162 [details]
Patch
Comment 2 youenn fablet 2020-11-15 09:54:16 PST 
Created attachment 414168 [details]
Patch
Comment 3 Yusuke Suzuki 2020-11-15 10:48:57 PST 
Comment on attachment 414168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414168&action=review

r=me

> Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:206
> +    if ((jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()->isSecureContext() && TestEnabledForContext::enabledForContext(*jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()))) {

Looks like we need to remove this brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:248
> +    if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) {

Ditto about the brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:251
> +    if (downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext())->settings().testSettingEnabled()) {

Ditto.

> Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:717
> +    if (RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) {

Ditto.
Comment 4 youenn fablet 2020-11-16 00:01:45 PST 
Created attachment 414197 [details]
Patch for landing
Comment 5 EWS 2020-11-16 04:18:12 PST 
Committed r269847: <https://trac.webkit.org/changeset/269847>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414197 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-16 04:19:16 PST 
<rdar://problem/71434621>