Created attachment 414286 [details]
Patch

Comment on attachment 414286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414286&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:-480
> -    m_contentType = contentType;

Is this really not needed if we end up in `nextBestMediaEngine`?

> Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:61
> +    return { };

You could call `notImplemented()` from all of these stub methods.

> Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:62
> +}

Ditto

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:637
> +    if (m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE) {
> +        auto identifier = RemoteMediaSourceIdentifier::generate();
> +        connection().send(Messages::RemoteMediaPlayerProxy::LoadMediaSource(url, identifier), m_id);
> +        m_mediaSourcePrivate = MediaSourcePrivateRemote::create(m_manager.gpuProcessConnection(), identifier, m_manager.typeCache(m_remoteEngineIdentifier), *this, client);
> +    } else {

You could use an early return here instead of the `else`

> Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:107
> +}

notImplemented()

> Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:85
> +}

Ditto

Created attachment 414304 [details]
Patch for landing

Comment on attachment 414286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414286&action=review

>> Source/WebCore/platform/graphics/MediaPlayer.cpp:-480
>> -    m_contentType = contentType;
> 
> Is this really not needed if we end up in `nextBestMediaEngine`?

Hmm, we may need it in that case. To be safe, I added the parameter back and changed MediaPlayerPrivate::load() accordingly.

>> Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:61
>> +    return { };
> 
> You could call `notImplemented()` from all of these stub methods.

Fixed.

>> Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:62
>> +}
> 
> Ditto

Fixed.

>> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:637
>> +    } else {
> 
> You could use an early return here instead of the `else`

Right! Fixed.

>> Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:107
>> +}
> 
> notImplemented()

Fixed.

>> Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:85
>> +}
> 
> Ditto

Fixed.

Committed r269907: <https://trac.webkit.org/changeset/269907>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414304 [details].

<rdar://problem/71489527>