Bug 218854 - [GTK][WPE] FilterInfo must cleared when reusing BitmapTextureGL
Summary: [GTK][WPE] FilterInfo must cleared when reusing BitmapTextureGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-12 09:51 PST by Miguel Gomez
Modified: 2020-11-13 00:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2020-11-12 09:55 PST, Miguel Gomez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2020-11-12 09:51:45 PST 
When a BitmapTextureGL is reused, its internal values are reset (flags, internal texture, and content). But the FilterInfo variable is not, so the every time that BitmapTextureGL is painted it will use the the old filter, altering the result.
Comment 1 Miguel Gomez 2020-11-12 09:55:02 PST 
Created attachment 413946 [details]
Patch
Comment 2 Fujii Hironori 2020-11-12 13:33:09 PST 
Good catch.
Are there any existing tests failing? If so, please add a comment about it. If not, can you add a new test?
Comment 3 Carlos Garcia Campos 2020-11-12 23:46:40 PST 
I think this will fix tests but on top pach attached to bug #215445. So, it will be covered by backdrop filter tests.
Comment 4 Miguel Gomez 2020-11-13 00:05:49 PST 
(In reply to Carlos Garcia Campos from comment #3)
> I think this will fix tests but on top pach attached to bug #215445. So, it
> will be covered by backdrop filter tests.

Yes, this together with the fix to bug #215445 will fix several backdrop filter related bugs.
Comment 5 EWS 2020-11-13 00:22:51 PST 
Committed r269765: <https://trac.webkit.org/changeset/269765>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413946 [details].