Bug 218703 - [JSC] Tests with an '-e' parameters in requireOptions fail with bytecode cache enabled
Summary: [JSC] Tests with an '-e' parameters in requireOptions fail with bytecode cach...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-11-09 03:53 PST by Xan Lopez
Modified: 2022-05-19 23:20 PDT (History)
3 users (show)

See Also:


Attachments
v1 (2.12 KB, patch)
2022-05-19 03:38 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2020-11-09 03:53:20 PST
Some stress tests have a line like:

//@ requireOptions("-e", "let iterations=1e5") if ["mips"].include?($architecture)

to reduce the number of iterations on MIPS (since its bots are slower).

This causes bugs with the bytecode cache enabled, seemingly because issues with (lack of) double quoting:

stress/generator-cell-with-type.js.bytecode-cache: Could not open file: iterations=1e5
stress/generator-cell-with-type.js.bytecode-cache: Exception: ReferenceError: Can't find variable: let
stress/generator-cell-with-type.js.bytecode-cache: global code@[Command Line]:1:4

This is a blocker to enable bytecode cache support on MIPS.
Comment 1 Xan Lopez 2022-05-19 03:09:25 PDT
I'm pretty sure now this is just a generic bug in how parameters are dealt with in the bytecode cache helper script. Patch incoming.
Comment 2 Xan Lopez 2022-05-19 03:38:05 PDT
Created attachment 459580 [details]
v1
Comment 3 Yusuke Suzuki 2022-05-19 22:37:35 PDT
Comment on attachment 459580 [details]
v1

r=me
Comment 4 EWS 2022-05-19 23:19:58 PDT
Committed r294532 (250787@main): <https://commits.webkit.org/250787@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459580 [details].