Bug 218468 - Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash
Summary: Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 218363
  Show dependency tree / graph
 
Reported: 2020-11-02 16:16 PST by Chris Dumez
Modified: 2020-11-02 17:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2020-11-02 16:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2020-11-02 16:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-11-02 16:16:16 PST 
imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash since r269227.
Comment 1 Chris Dumez 2020-11-02 16:16:26 PST 
<rdar://problem/70969071>
Comment 2 Chris Dumez 2020-11-02 16:19:33 PST 
Created attachment 412986 [details]
Patch
Comment 3 Darin Adler 2020-11-02 16:40:38 PST 
Comment on attachment 412986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412986&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:116
> +                auto* context = scriptExecutionContext();
> +                if (!context)
> +                    return;
> +
> +                auto registration = ServiceWorkerRegistration::getOrCreate(*context, *this, WTFMove(registrationData));

Not sure this needs a blank line.
Comment 4 Chris Dumez 2020-11-02 16:42:30 PST 
Created attachment 412988 [details]
Patch
Comment 5 EWS 2020-11-02 17:15:19 PST 
Committed r269281: <https://trac.webkit.org/changeset/269281>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412988 [details].