Bug 218420 - [LFC][IFC] Empty lines stay empty even when the imaginary strut is present
Summary: [LFC][IFC] Empty lines stay empty even when the imaginary strut is present
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-31 20:49 PDT by zalan
Modified: 2020-11-09 13:52 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2020-10-31 21:13 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2020-11-01 14:00 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-31 20:49:21 PDT
ssia
Comment 1 zalan 2020-10-31 21:13:43 PDT
Created attachment 412859 [details]
Patch
Comment 2 zalan 2020-11-01 14:00:05 PST
Created attachment 412871 [details]
Patch
Comment 3 EWS 2020-11-02 06:12:16 PST
Committed r269245: <https://trac.webkit.org/changeset/269245>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412871 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-02 06:13:21 PST
<rdar://problem/70947450>
Comment 5 zalan 2020-11-02 14:07:08 PST
Reverted r269245 for reason:

3 LFC tests asserting in WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree

Committed r269274: <https://trac.webkit.org/changeset/269274>
Comment 6 zalan 2020-11-09 13:52:02 PST
fixed differently