Created attachment 412663 [details] Patch

Looks ok to me. boto3.client accepts the endpoint_url argument with no value. (Note, I am not a reviewer, so can't r+).

What is the motivation for this change?

(In reply to Jonathan Bedard from comment #3) > What is the motivation for this change? The motivation is being able to run a replica of the buildbot infra in a staging environment, so as to be able to try out proposed configuration changes before rolling them out in the live environment. In order to do that, we need to run separate (throwaway) instances of the buildbot server and also be able to override the use of specific S3 buckets. We could do that by resolving the hardcoded amazon addresses to local IPs, but then we'd also need to create a private CA, propagate the certs etc. With the proposed change, we can simply have the endpoint url be http://something:someport so that things trivially work out of the box. A separate patch would add the ability to override the hardcoded S3URL in ews-build/steps.py.

After discussing things with Aakash Jain, I'll be submitting patches along a different direction.

Basically we don't need to modify this script. Instead testing instances should completely skip the transfer-to-s3 step. Done in https://bugs.webkit.org/show_bug.cgi?id=218439