Bug 218287 - We have too many ways of overriding preferences in LayoutTests
Summary: We have too many ways of overriding preferences in LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 218288 218417
Blocks:
  Show dependency tree / graph
 
Reported: 2020-10-28 09:09 PDT by Sam Weinig
Modified: 2020-11-01 12:05 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-28 09:09:21 PDT 
We have too many ways of overriding preferences in LayoutTests - test header commands, internals.settings, testRunner.overridePreference, and testRunner specific functions.

We should standardize on just test header commands for static configuration (as this is the only method that allows the preference to be set prior to a test run) and internals.settings as this is completely generated and allows dynamic setting of preferences.