Sources.txt and SourcesCocoa.txt were added to the WebKitLegacy project in https://trac.webkit.org/changeset/247401 as targets of the WebKitLegacy target. This caused them to be treated as resources and so were copied to the framework's Resources directory on a build. These files don't need to be included in the build, and so need to be removed from that target.
<rdar://problem/70742539>
Created attachment 412489 [details] Patch
Does this leave them in the project? I think they should be in the project, just not a part of any target
Yes, they're still in the project, so you can select and open them. They were merely removed from the target.
Seems reasonable to me.
Don't we have a script that checks for files added to frameworks by mistake? Why didn't it catch this?
"Check For Inappropriate Files In Framework"
check-for-inappropriate-files-in-framework needs to be attached to WebKitLegacy (and JavaScriptCore) and updated to scan for *.txt files.
Committed r269093: <https://trac.webkit.org/changeset/269093> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412489 [details].