Bug 218255 - Fix "usage" message when invoking `ar -V`
Summary: Fix "usage" message when invoking `ar -V`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 13:16 PDT by Keith Rollin
Modified: 2020-10-27 16:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2020-10-27 13:18 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-10-27 13:16:31 PDT 
The Mac/BSD version of `ar` does not support the -V flag. This flag is used unconditionally in OptionsCommon.cmake when trying to determine if the installed `ar` supports the thinning of archives, leading to a "usage" message being emitted on macOS.

Avoid this message by capturing the error-output. Examine the output to see if it's a "usage" message. If so, then treat the `ar` as one that does not support thinning. Any other error-output is printed as a warning. If there is no error-output, continue processing as normal.
Comment 1 Radar WebKit Bug Importer 2020-10-27 13:16:43 PDT 
<rdar://problem/70735674>
Comment 2 Keith Rollin 2020-10-27 13:18:53 PDT 
Created attachment 412455 [details]
Patch
Comment 3 EWS 2020-10-27 14:54:30 PDT 
Committed r269076: <https://trac.webkit.org/changeset/269076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412455 [details].