Bug 218248 - [GStreamer] Mock video source doesn't set framerate on its caps
Summary: [GStreamer] Mock video source doesn't set framerate on its caps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 11:03 PDT by Philippe Normand
Modified: 2020-10-28 06:14 PDT (History)
14 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2020-10-27 11:05 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-10-27 11:03:36 PDT 
.
Comment 1 Philippe Normand 2020-10-27 11:05:51 PDT 
Created attachment 412447 [details]
Patch
Comment 2 Philippe Normand 2020-10-27 11:39:09 PDT 
Comment on attachment 412447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412447&action=review

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:-73
> -    auto buffer = adoptGRef(gst_buffer_new_wrapped(g_memdup(data.releaseBuffer().get(), size), size));

A memcpy is avoided as well
Comment 3 EWS 2020-10-28 06:13:41 PDT 
Committed r269101: <https://trac.webkit.org/changeset/269101>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412447 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-28 06:14:42 PDT 
<rdar://problem/70762061>