Bug 218233 - [LFC][Integration] Use iterator for next/previousLinePosition
Summary: [LFC][Integration] Use iterator for next/previousLinePosition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 07:41 PDT by Antti Koivisto
Modified: 2020-10-27 10:43 PDT (History)
14 users (show)

See Also:

Attachments
patch (26.11 KB, patch)
2020-10-27 07:45 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-10-27 07:41:19 PDT 
In VisibleUnit.cpp
Comment 1 Antti Koivisto 2020-10-27 07:45:11 PDT 
Created attachment 412420 [details]
patch
Comment 2 zalan 2020-10-27 08:42:57 PDT 
Comment on attachment 412420 [details]
patch

nice
Comment 3 EWS 2020-10-27 08:57:20 PDT 
Committed r269041: <https://trac.webkit.org/changeset/269041>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412420 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-27 08:58:19 PDT 
<rdar://problem/70723663>
Comment 5 Philippe Normand 2020-10-27 10:14:44 PDT 
This broke the Debian and Ubuntu LTS bots: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Debian-Stable-Build/builds/38868
Comment 6 Carlos Alberto Lopez Perez 2020-10-27 10:38:53 PDT 
Seems is an issue with unified builds and includes. Those bots compile with different build options than the defaults so the include order on the unified builds is different. I have a fix for it, will land it
Comment 7 Carlos Alberto Lopez Perez 2020-10-27 10:43:41 PDT 
Committed r269053: <https://trac.webkit.org/changeset/269053>