Bug 218210 - Improve exception messages when AudioContext.suspend() / resume() promises are rejected
Summary: Improve exception messages when AudioContext.suspend() / resume() promises ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611 217606
  Show dependency tree / graph
 
Reported: 2020-10-26 15:13 PDT by Chris Dumez
Modified: 2020-10-26 17:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2020-10-26 15:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-26 15:13:01 PDT 
Improve exception messages when AudioContext.suspend() / resume() promises are rejected.
Comment 1 Chris Dumez 2020-10-26 15:14:59 PDT 
Created attachment 412359 [details]
Patch
Comment 2 Geoffrey Garen 2020-10-26 15:50:30 PDT 
Comment on attachment 412359 [details]
Patch

r=me
Comment 3 Chris Dumez 2020-10-26 16:09:21 PDT 
Comment on attachment 412359 [details]
Patch

Clearing flags on attachment: 412359

Committed r268999: <https://trac.webkit.org/changeset/268999>
Comment 4 Chris Dumez 2020-10-26 16:09:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-10-26 16:10:17 PDT 
<rdar://problem/70699860>
Comment 6 Darin Adler 2020-10-26 17:38:37 PDT 
Comment on attachment 412359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412359&action=review

> LayoutTests/webaudio/construct-node-with-closed-context-expected.txt:45
> +PASS context.resume() rejected promise  with InvalidStateError: Context is closed.
>  PASS context.close() rejected promise  with InvalidStateError: The object is in an invalid state..

Why do some of our error messages end with periods, and others not?