Bug 218203 - evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
Summary: evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-26 13:57 PDT by Stephan Szabo
Modified: 2020-10-26 16:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2020-10-26 14:44 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-10-26 13:57:51 PDT 
We found on our port where we have RELEASE_LOG_DISABLED set that evictCodedFrames would sometimes evict after the current position even if it freed up enough space during the first part of the eviction.

It looks like a log change from a while ago changed the block that checked whether the buffer was still full and to log and return to only happen if logging was not disabled which changed the behavior since the return no longer happened either.
Comment 1 Stephan Szabo 2020-10-26 14:44:27 PDT 
Created attachment 412356 [details]
Patch
Comment 2 EWS 2020-10-26 16:47:23 PDT 
Committed r269001: <https://trac.webkit.org/changeset/269001>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412356 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-26 16:48:18 PDT 
<rdar://problem/70701318>