Bug 218174 - [EME][GStreamer] Fix logging in utilities
Summary: [EME][GStreamer] Fix logging in utilities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on:
Blocks: 218175
  Show dependency tree / graph
 
Reported: 2020-10-26 04:09 PDT by Xabier Rodríguez Calvar
Modified: 2020-10-27 04:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2020-10-26 04:11 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2020-10-26 04:09:01 PDT 
[EME][GStreamer] Fix logging in utilities
Comment 1 Xabier Rodríguez Calvar 2020-10-26 04:11:22 PDT 
Created attachment 412303 [details]
Patch
Comment 2 Philippe Normand 2020-10-26 04:42:15 PDT 
Comment on attachment 412303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412303&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:36
> +GST_DEBUG_CATEGORY_EXTERN(webkit_media_common_encryption_decrypt_debug_category);

OK I am lost in all the bugs you opened :) Why not handle everything in a single patch?
Comment 3 Xabier Rodríguez Calvar 2020-10-26 08:01:36 PDT 
(In reply to Philippe Normand from comment #2)
> Comment on attachment 412303 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412303&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:36
> > +GST_DEBUG_CATEGORY_EXTERN(webkit_media_common_encryption_decrypt_debug_category);
> 
> OK I am lost in all the bugs you opened :) Why not handle everything in a
> single patch?

Don't get lost, they just have consecutive numbers almost all of them!

Now speaking more serious, they tackled different things, at least most of them
Comment 4 EWS 2020-10-27 04:41:01 PDT 
Committed r269031: <https://trac.webkit.org/changeset/269031>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412303 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-27 04:42:23 PDT 
<rdar://problem/70717707>